UnknownError: TimeoutError: The operation timed out.

github run

@erikcorry Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.69%. Comparing base (bbf4df7) to head (a822af5).

@@            Coverage Diff             @@
##             main    #6426      +/-   ##
==========================================
- Coverage   70.71%   70.69%   -0.02%     
==========================================
  Files         427      427              
  Lines      117262   117262              
  Branches    18903    18903              
==========================================
- Hits        82917    82904      -13     
- Misses      23093    23102       +9     
- Partials    11252    11256       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merging this PR will degrade performance by 13.04%

❌ 1 regressed benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

_{Comparing erikcorry/simdutf-better-patch (a822af5) with main (bbf4df7)}

The PR has already been approved by anonrig. Let me do my analysis:

Summary of the PR:

This PR removes the C++ source file modifications from the V8 patch 0018-Modify-where-to-look-for-fast_float-and-simdutf.patch. Previously, the patch both:

1. Modified V8's BUILD.bazel to use external @simdutf and @fast_float deps instead of the vendored ones
2. Changed #include "third_party/simdutf/simdutf.h" to #include "simdutf.h" across multiple V8 C++ files

The PR keeps only the BUILD.bazel changes (part 1) and instead adds include_prefix = "third_party/simdutf" to workerd's build/BUILD.simdutf so that Bazel provides the headers at the path V8 already expects (third_party/simdutf/simdutf.h). This means V8's C++ source files don't need to be patched at all for include paths, making the patched V8 still compilable with gn (Google's build system).

The fast_float dep already had this treatment (its build_file_content in deps.MODULE.bazel already has include_prefix = 'third_party/fast_float/src').

This is a clean improvement that reduces the V8 patch surface, making future V8 updates easier. The approach is sound — include_prefix in Bazel's cc_library makes headers available under a virtual path, so V8's original #include "third_party/simdutf/simdutf.h" works unchanged.

No logic bugs, no security issues, no backward compatibility concerns, no missing compat flags. The CodSpeed regression is on a micro-benchmark and unlikely related to this change (it only affects include paths, not runtime code).

LGTM

github run