Fix cloudflare.ray_id not being set correctly for subrequests#6425
Merged
danlapid merged 1 commit intocloudflare:mainfrom Mar 26, 2026
Merged
Fix cloudflare.ray_id not being set correctly for subrequests#6425danlapid merged 1 commit intocloudflare:mainfrom
danlapid merged 1 commit intocloudflare:mainfrom
Conversation
We were previously setting `cloudflare.ray_id` to the _request_ cf-ray header if present and ONLY if there was a request body. This is incorrect. We want to set it to the _response_ header and always not only if there is a body. This moves the ray setting down to where the response is returned and ensures it is properly set when expected
e757e18 to
2e6785d
Compare
danlapid
approved these changes
Mar 26, 2026
jasnell
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously setting
cloudflare.ray_idto the request cf-ray header if present and ONLY if there was a request body.This is incorrect. We want to set it to the response header and always not only if there is a body.
This moves the ray setting down to where the response is returned and ensures it is properly set when expected