Move a handful of patches out to workerd#6397
Merged
Conversation
anonrig
approved these changes
Mar 24, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
danlapid
approved these changes
Mar 24, 2026
dcarney-cf
approved these changes
Mar 24, 2026
Node.js JWK public key import for OKP curves incorrectly treated the public "x" parameter as a private key seed, producing a mismatched key pair. Use the raw public key constructor and add regression coverage for Ed25519 and X25519 JWK public key imports.
AsymmetricKey::exportKeyExt() accepted cipher and passphrase parameters but never forwarded them to the PrivateKeyEncodingConfig passed to writePrivateKey(). The config was constructed with only (false, formatType, encType), leaving its cipher and passphrase fields at their defaults (nullptr / nullopt). This caused writePrivateKey() to always produce an unencrypted PEM regardless of what the caller requested. Populate config.cipher via ncrypto::getCipherByName() and config.passphrase via DataPointer::Alloc() before passing the config to writePrivateKey(), matching the pattern already used by tryParsingPrivate() in the same file. Add regression tests for RSA and EC encrypted private key export round-trips.
9f69e90 to
2cdf76a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.