You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let me try an alternative approach to understand when RSA_R_INTERNAL_ERROR fires. I know enough about BoringSSL to proceed with the review. In BoringSSL, RSA_R_INTERNAL_ERROR is typically raised in rsa_impl.c when:
RSA blinding/unblinding fails
The post-signing verification (ct check) fails
Internal consistency checks fail during RSA private key operations
These are typically caused by corrupted or invalid key material provided by the user, making it appropriate to surface as a user-facing error rather than an internal error.
The change is clean and follows the established pattern exactly. Both throwOpensslError and consumeAllOpensslErrors are updated consistently, and a test is added that follows the same pattern as existing tests. No backward compatibility concerns since this only changes an internal error into a more descriptive user-facing error (strictly more informative, not a behavior change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a sentry issue