Skip to content

Revert "Move wildcard properties to instance template"#6172

Merged
dcarney-cf merged 2 commits intomainfrom
revert-6090-dcarney/patch-this
Feb 25, 2026
Merged

Revert "Move wildcard properties to instance template"#6172
dcarney-cf merged 2 commits intomainfrom
revert-6090-dcarney/patch-this

Conversation

@mar-cf
Copy link
Copy Markdown
Contributor

@mar-cf mar-cf commented Feb 25, 2026

Reverts #6090

@mar-cf mar-cf requested review from jasnell and kentonv February 25, 2026 04:29
@mar-cf mar-cf requested review from a team as code owners February 25, 2026 04:29
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Feb 25, 2026

Now I have a clear picture. This is a clean revert of PR #6090. Let me verify the diff is indeed a complete revert by examining it carefully.

Key observations:

  1. PR Move wildcard properties to instance template #6090 moved wildcard property interceptors from prototype to instance template. It also added a V8 patch (0033) to fix hasOwnProperty behavior with interceptors, added a query callback, changed info.This() to info.HolderV2(), and added wildcard propagation logic for inheritance.

  2. This revert undoes all of that cleanly: restores the handler on the prototype template, removes the V8 patch, removes the query callback, restores info.This(), removes the wildcard propagation in registerInherit, and re-adds the deprecation warning suppression pragmas.

  3. The revert is a faithful inverse — the resulting code matches the state before Move wildcard properties to instance template #6090 was merged.

This is a straightforward GitHub-generated revert. The code changes are mechanically correct — they restore the pre-#6090 state exactly. No new logic is introduced, and no subtle differences exist between the reverted state and the original pre-merge state.

LGTM

github run

@mar-cf mar-cf requested a review from dcarney-cf February 25, 2026 04:36
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 25, 2026

Merging this PR will degrade performance by 21.17%

❌ 2 regressed benchmarks
✅ 68 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
Encode_ASCII_32[TextEncoder][0/0/32] 3.1 ms 3.4 ms -10.94%
bodyWithHeaders[Response] 30 µs 38.1 µs -21.17%

Comparing revert-6090-dcarney/patch-this (c62e69b) with main (522277a)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@dcarney-cf dcarney-cf enabled auto-merge February 25, 2026 11:14
@dcarney-cf dcarney-cf merged commit 87c1281 into main Feb 25, 2026
22 of 24 checks passed
@dcarney-cf dcarney-cf deleted the revert-6090-dcarney/patch-this branch February 25, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants