The fix is sound. The test works but is heavier than needed. However, the test is pragmatic — it clearly demonstrates the issue and the error message in the JSG_REQUIRE is clear. This is a defensive check that prevents a much worse outcome (V8 crash or undefined behavior).

Let me check if there are any other concerns — backward compatibility (this is a new error where none existed before):

The change introduces a new RangeError where previously V8 would have either crashed or thrown a less descriptive error. This is strictly an improvement — it makes an error case produce a clean, user-understandable error message. Since the previous behavior was an error/crash anyway (you can't create a V8 string larger than kMaxLength), this doesn't change any successful behavior. No compat flag needed.

LGTM

github run