Conversation
Contributor
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR tightens the generator byte-array size check in createDiffieHellman from INT32_MAX to OPENSSL_DH_MAX_MODULUS_BITS / CHAR_BIT (1250 bytes), consistent with the existing key size check. The C++ change looks correct.
Issues (ranked by severity):
- Test uses undefined references —
throwsandcreateDiffieHellmanare not imported or destructured. The rest of the file usesassert.throwsandcrypto.createDiffieHellman. This test will fail at runtime with aReferenceErrorrather than actually validating the new limit.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
anonrig
approved these changes
Feb 24, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not breaking because larger values would have hit CPU and memory limits causing them to fail in other ways.