You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've thoroughly reviewed the entire PR. Let me summarize what I found:
assertions.ts changes: Adds codename_name_map, name_code_map, code_name_map lookup tables, an assert_dom helper, and assert_throws_dom_impl -- a reimplementation of the upstream WPT assert_throws_dom logic that handles legacy DOMException code names and provides better error messages. The existing assert_throws_dom is updated to delegate to the new implementation.
websockets-test.ts changes: Removes several expectedFailures entries for tests that were failing because the old implementation didn't handle legacy code names like SYNTAX_ERR. Also converts Close-1005.any.js from disabledTests: true to expectedFailures with a cleanup to prevent hanging.
The code is clean, correctly matches the upstream WPT testharness.js patterns, the == at line 467 is intentional (upstream uses loose equality for DOMException property comparison), and the lookup tables match the WebIDL error names table. The websocket test changes are well-motivated with clear comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.