Conversation
|
The changes are straightforward:
All three platform entries are consistently updated. The LGTM |
5845707 to
eb74316
Compare
jasnell
left a comment
There was a problem hiding this comment.
AI-generated review — may contain errors.
Summary
Clean, mechanical update from clang-tidy 21.1.4 → 22.1.0. Three categories of changes:
- Toolchain version bump:
build_deps.jsonc,build_deps.MODULE.bazel(sha256 + URLs),compile_flags.txt(llvm-22 include paths) .clang-tidyconfig adjustments: disable new noisy checks (-readability-redundant-parentheses), addmodernize-use-string-view, movemodernize-avoid-variadic-functionsto TODO, note newbugprone-derived-method-shadowing-base-methodfor future enablement- Redundant
typenameremoval across ~28 files: C++20 (P0634R3) madetypenameoptional in contexts where only a type is valid (using declarations, default template args, trailing return types, friend declarations). All removals are correct for C++23.
Findings
No blocking issues. Two minor observations:
- [LOW] Pre-existing:
bugprone-return-const-ref-from-parameteris both enabled (active checks) and listed in the TODO comment section —.clang-tidy:16vs.clang-tidy:68. Not introduced by this PR; just noting for future cleanup. - [INFO]
modernize-avoid-variadic-functionsdemotion — moved from active checks to TODO. It might be worth a brief comment in the TODO section explaining why (new false positives in 22?) to help future readers understand the intent.
eb74316 to
c5795b0
Compare
Adds support for readability-redundant-typename check
c5795b0 to
92b3fa5
Compare
Merging this PR will degrade performance by 16.21%
Performance Changes
Comparing Footnotes
|
Adds support for readability-redundant-typename check.