Skip to content

Use enum for Pyodide version#6149

Merged
ryanking13 merged 1 commit intomainfrom
gyeongjae/enum-version
Feb 24, 2026
Merged

Use enum for Pyodide version#6149
ryanking13 merged 1 commit intomainfrom
gyeongjae/enum-version

Conversation

@ryanking13
Copy link
Copy Markdown
Contributor

NFC, replaces raw strings to const

@ryanking13 ryanking13 requested review from dom96 and hoodmane February 24, 2026 06:57
@ryanking13 ryanking13 requested review from a team as code owners February 24, 2026 06:57
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Feb 24, 2026

All changes are coherent and correct. This is a clean build maintenance PR:

  1. Removing Dawn-related ObjC workarounds from .bazelrc
  2. Adding brew update before brew install lld in CI for lld 20
  3. Enabling SSE4.2 for simdutf on x86_64 with targeted warning suppression instead of blanket -w
  4. IWYU cleanups across multiple targets (moving deps to implementation_deps, swapping files between node and node-core targets based on their actual dependencies)
  5. Cleaning up redundant empty Bazel attributes and allow_empty/.js globs
  6. Updating comments to reflect Dawn removal

Nothing looks problematic — the dependency movements are all validated by the actual includes, and there are no behavioral changes.

LGTM

github run

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 24, 2026

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@ryanking13 ryanking13 force-pushed the gyeongjae/enum-version branch from a48abee to f914f12 Compare February 24, 2026 07:38
@ryanking13
Copy link
Copy Markdown
Contributor Author

The bonk seems to be confused this with other PR?

@ryanking13 ryanking13 force-pushed the gyeongjae/enum-version branch from f914f12 to c3d16a6 Compare February 24, 2026 10:08
@ryanking13 ryanking13 force-pushed the gyeongjae/enum-version branch from c3d16a6 to 8cb783a Compare February 24, 2026 10:13
@dom96
Copy link
Copy Markdown
Contributor

dom96 commented Feb 24, 2026

Yeah, seems Bonk got confused about the PR number somehow?

Screenshot 2026-02-24 at 10 14 28

Copy link
Copy Markdown
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for doing this, it will make it much harder for us to typo a version.

@ryanking13 ryanking13 enabled auto-merge February 24, 2026 10:45
@ryanking13 ryanking13 merged commit 0a7b469 into main Feb 24, 2026
24 checks passed
@ryanking13 ryanking13 deleted the gyeongjae/enum-version branch February 24, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants