Skip to content

Fixup lock handling in limit enforcer and compile cache.#6121

Merged
mar-cf merged 1 commit intomainfrom
mar/lockfix
Feb 23, 2026
Merged

Fixup lock handling in limit enforcer and compile cache.#6121
mar-cf merged 1 commit intomainfrom
mar/lockfix

Conversation

@mar-cf
Copy link
Copy Markdown
Contributor

@mar-cf mar-cf commented Feb 20, 2026

No description provided.

@mar-cf mar-cf requested a review from jasnell February 20, 2026 17:41
@mar-cf mar-cf requested review from a team as code owners February 20, 2026 17:41
@mar-cf
Copy link
Copy Markdown
Contributor Author

mar-cf commented Feb 20, 2026

@jasnell did we land on a compile time catch for this?

@jasnell
Copy link
Copy Markdown
Collaborator

jasnell commented Feb 20, 2026

did we land on a compile time catch for this?

Not that I'm aware of. @danlapid was looking into it

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 20, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 70 untouched benchmarks
⏩ 129 skipped benchmarks1

Comparing mar/lockfix (70da2f6) with main (edacbb5)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@danlapid
Copy link
Copy Markdown
Collaborator

danlapid commented Feb 20, 2026

@mar-cf @jasnell haven't had time to make it merge-ready
Feel free to pick it up:
https://github.com/capnproto/capnproto/pull/new/dlapid/lockSafety
https://github.com/cloudflare/workerd/pull/new/dlapid/lockSafety
https://gitlab.cfdata.org/cloudflare/ew/edgeworker/-/merge_requests/new?merge_request%5Bsource_branch%5D=dlapid%2FlockSafety

@jasnell
Copy link
Copy Markdown
Collaborator

jasnell commented Feb 21, 2026

@mar-cf ... you'll likely need to rebase this on main to deal with spurious test failure on widows.

@mar-cf mar-cf enabled auto-merge February 23, 2026 01:00
@mar-cf mar-cf merged commit 8496472 into main Feb 23, 2026
45 of 48 checks passed
@mar-cf mar-cf deleted the mar/lockfix branch February 23, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mar-cf @jasnell @danlapid @anonrig