Skip to content

Add missing string | Blob overloads to FormData append() and set()#5961

Merged
anonrig merged 2 commits intomainfrom
yagiz/fix-formdata-overloads
Jan 28, 2026
Merged

Add missing string | Blob overloads to FormData append() and set()#5961
anonrig merged 2 commits intomainfrom
yagiz/fix-formdata-overloads

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Jan 27, 2026

Fixes #5934

@anonrig anonrig requested review from a team as code owners January 27, 2026 14:12
@anonrig anonrig enabled auto-merge (squash) January 27, 2026 14:15
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.15%. Comparing base (f107510) to head (3b21888).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5961   +/-   ##
=======================================
  Coverage   70.14%   70.15%           
=======================================
  Files         407      407           
  Lines      107190   107190           
  Branches    17966    17966           
=======================================
+ Hits        75193    75194    +1     
+ Misses      21214    21213    -1     
  Partials    10783    10783           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test?

@vicb vicb self-requested a review January 27, 2026 14:55
@vicb vicb disabled auto-merge January 27, 2026 14:56
@vicb
Copy link
Copy Markdown
Contributor

vicb commented Jan 27, 2026

@anonrig sorry, I disabled auto-merge because I have question (even if I approve). I generally don't like auto-merge for that!

@anonrig anonrig force-pushed the yagiz/fix-formdata-overloads branch 3 times, most recently from ddb0bf1 to c88a28d Compare January 27, 2026 15:54
@anonrig anonrig enabled auto-merge (squash) January 27, 2026 15:55
@anonrig anonrig requested a review from npaun January 27, 2026 20:47
auto-merge was automatically disabled January 27, 2026 21:53

Head branch was modified

@anonrig anonrig force-pushed the yagiz/fix-formdata-overloads branch from c88a28d to 3b21888 Compare January 27, 2026 21:53
@anonrig anonrig enabled auto-merge January 27, 2026 21:53
@anonrig anonrig merged commit d615272 into main Jan 28, 2026
22 of 23 checks passed
@anonrig anonrig deleted the yagiz/fix-formdata-overloads branch January 28, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing overloads in FormData type definition

5 participants