Add tests for internal stream error paths#5931

Merged

anonrig merged 1 commit intomainfrom

yagiz/add-tests-internal-stream-error

Jan 20, 2026

Member

anonrig commented Jan 20, 2026

The tests added with this pull-request:

Tests for WritableStreamInternalController:

close/flush/tryPipeFrom reject with "currently being piped to" during active pipe

Tests for ReadableStreamInternalController drainingRead:

Returns done=true on closed stream
Propagates I/O errors from underlying source
Rejects concurrent reads with "single pending read" error

anonrig requested a review from jasnell

January 20, 2026 15:06

anonrig requested review from a team as code owners

January 20, 2026 15:06

This comment was marked as off-topic.

Sign in to view

jasnell reviewed

View reviewed changes

src/workerd/api/streams/internal-test.c++ Outdated Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/streams/internal-test.c++ Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/streams/internal-test.c++ Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/streams/internal-test.c++ Outdated Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/streams/internal-test.c++ Outdated Show resolved Hide resolved


          Add tests for internal stream error paths

9607f83

anonrig force-pushed the yagiz/add-tests-internal-stream-error branch from 8adcc27 to 9607f83 Compare

January 20, 2026 15:34

anonrig requested a review from jasnell

January 20, 2026 15:35

jasnell approved these changes

View reviewed changes

anonrig merged commit 2a8e04f into main

22 checks passed

anonrig deleted the yagiz/add-tests-internal-stream-error branch

January 20, 2026 17:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet