You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tcmalloc is extremely flaky while running benchmarks. This change would reduce the probability of outliers at the cost of diverging from production. For benchmarks that need tcmalloc to use the default values, they have to avoid including bench-tools.
I think we'll need to select() based on //src/workerd/server:really_use_tcmalloc instead to handle the case of sanitizer builds (no tcmalloc but may be Linux) correctly. You may need to make that target public first for this to work.
Edit: Asan CI has passed – perhaps because we don't build benchmarks in the ASan job?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tcmalloc is extremely flaky while running benchmarks. This change would reduce the probability of outliers at the cost of diverging from production. For benchmarks that need tcmalloc to use the default values, they have to avoid including bench-tools.
Recommended by Codspeed folks.