update-deps.py: Allow bazel_dep + archive/git_override#5876
Merged
Conversation
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
59df4a3 to
a8a1239
Compare
a8a1239 to
d5dea05
Compare
d5dea05 to
2fadb42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag to our existing dependency types for downloading packages:
github_releasegithub_tarballgit_cloneIf
use_bazel_dep: trueis set, we generate abazel_dep()+ an override directive (e.g.archive_override()orgit_override(). Otherwise, we use the existing templates for aWORKSPACEbased repo.Additionally
use_module_bazel_from_bcr: some.version.herecan be used to automatically download an inject aMODULE.bazelfile from BCR if one is available from there, but not in the project itself.This is basically the last PR in my project of upgrading
update-deps.py. There's probably still room for small simplifications / cleanups down the road, but the vast majority of our dependencies are now automated again.