Skip to content

Improve Windows CI build performance#5803

Merged
danlapid merged 1 commit intomainfrom
dlapid/ci-improvements2
Dec 31, 2025
Merged

Improve Windows CI build performance#5803
danlapid merged 1 commit intomainfrom
dlapid/ci-improvements2

Conversation

@danlapid
Copy link
Copy Markdown
Collaborator

@danlapid danlapid commented Dec 31, 2025 •
edited
Loading

A quicky just to reduce CI times on windows by a fair bit - enable developer mode to support real symlinks.

@danlapid danlapid changed the base branch from main to dlapid/ci-improvements December 31, 2025 10:43
@danlapid danlapid force-pushed the dlapid/ci-improvements2 branch 2 times, most recently from 03fdf8b to 1e1c3c8 Compare December 31, 2025 11:48
@danlapid danlapid changed the base branch from dlapid/ci-improvements to main December 31, 2025 12:52
@danlapid danlapid force-pushed the dlapid/ci-improvements2 branch from 1e1c3c8 to 88e055d Compare December 31, 2025 12:52
@danlapid danlapid marked this pull request as ready for review December 31, 2025 12:52
@danlapid danlapid requested review from a team as code owners December 31, 2025 12:52
@danlapid
Improve windows CI performance
07a9275 
Seems like we need to use Developer Mode to get real symlinks in windows.
From bazel profiles this seems to reduce symlink times by a ton.
A drive by here is to always upload bazel profiles and report disk usage
so that we have them available even for runs where a test flakes.
@danlapid danlapid force-pushed the dlapid/ci-improvements2 branch from 88e055d to 07a9275 Compare December 31, 2025 12:53
@danlapid danlapid changed the title Improve CI build performance, especially on macOS Improve Windows CI build performance Dec 31, 2025
@danlapid danlapid enabled auto-merge December 31, 2025 13:10
@danlapid danlapid merged commit 40c37ed into main Dec 31, 2025
19 of 20 checks passed
@danlapid danlapid deleted the dlapid/ci-improvements2 branch December 31, 2025 13:11
@fhanau
Copy link
Copy Markdown
Contributor

fhanau commented Dec 31, 2025

I don't think this will have any effect – developer mode should already be enabled on the Windows CI image: https://github.com/actions/runner-images/blob/win25/20251216.149/images/windows/scripts/build/Configure-DeveloperMode.ps1#L13
We've also instructed Bazel to assume that symlink support is available (see .bazelrc), if this wasn't the case then builds would be failing: https://bazel.build/configure/windows#symlink

@danlapid
Copy link
Copy Markdown
Collaborator Author

danlapid commented Dec 31, 2025

I don't think this will have any effect – developer mode should already be enabled on the Windows CI image: actions/runner-images@win25/20251216.149/images/windows/scripts/build/Configure-DeveloperMode.ps1#L13 We've also instructed Bazel to assume that symlink support is available (see .bazelrc), if this wasn't the case then builds would be failing: bazel.build/configure/windows#symlink

I thought the same but this definitely showed up significant speed ups in bazel profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danlapid @fhanau @anonrig