Skip to content

[build] Enable clang-tidy modernize-loop-convert check#5801

Merged
fhanau merged 1 commit intomainfrom
felix/123025-expand-clang-tidy
Jan 26, 2026
Merged

[build] Enable clang-tidy modernize-loop-convert check#5801
fhanau merged 1 commit intomainfrom
felix/123025-expand-clang-tidy

Conversation

@fhanau
Copy link
Copy Markdown
Contributor

@fhanau fhanau commented Dec 30, 2025

No description provided.

anonrig
anonrig reviewed Dec 30, 2025
View reviewed changes
@fhanau fhanau force-pushed the felix/123025-expand-clang-tidy branch 2 times, most recently from cacf227 to 296b4a5 Compare January 5, 2026 21:49
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 5, 2026 •
edited
Loading

Merging this PR will degrade performance by 11.54%

❌ 1 regressed benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ simpleStringBody[Response] 19 µs 21.5 µs -11.54%

Comparing felix/123025-expand-clang-tidy (c75c55d) with main (66745cd)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@fhanau fhanau force-pushed the felix/123025-expand-clang-tidy branch from 296b4a5 to 398009f Compare January 26, 2026 18:12
@fhanau fhanau changed the title [build] Expand clang-tidy coverage [build] Enable clang-tidy modernize-loop-convert check Jan 26, 2026
@fhanau fhanau marked this pull request as ready for review January 26, 2026 18:13
@fhanau fhanau requested review from a team as code owners January 26, 2026 18:13
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 26, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.00%. Comparing base (66745cd) to head (c75c55d).

Files with missing lines Patch % Lines
src/workerd/io/trace.c++ 50.00% 1 Missing and 1 partial ⚠️
src/workerd/jsg/url-test.c++ 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5801      +/-   ##
==========================================
- Coverage   70.01%   70.00%   -0.01%     
==========================================
  Files         406      406              
  Lines      107106   107106              
  Branches    17965    17965              
==========================================
- Hits        74988    74983       -5     
- Misses      21321    21328       +7     
+ Partials    10797    10795       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fhanau fhanau force-pushed the felix/123025-expand-clang-tidy branch from 398009f to c75c55d Compare January 26, 2026 18:39
@fhanau fhanau merged commit c5c79e0 into main Jan 26, 2026
22 checks passed
@fhanau fhanau deleted the felix/123025-expand-clang-tidy branch January 26, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig left review comments

@npaun npaun npaun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fhanau @codecov-commenter @anonrig @npaun