fix ReadableStream.from() cancel behavior per WPT spec#5794
Merged
Conversation
|
The generated output of |
770b7d6 to
b25e45c
Compare
guybedford
reviewed
Dec 29, 2025
Collaborator
|
The plan is to eventually add a default-on date for |
b25e45c to
6fd01d4
Compare
jasnell
requested changes
Dec 29, 2025
Collaborator
jasnell
left a comment
There was a problem hiding this comment.
I believe this should be addressed in the impl of return_(...) more generally rather than being specific to ReadableStream.from().
6fd01d4 to
59907b7
Compare
Collaborator
|
It would be good to update the generator tests directly in addition to just enabling the streams related wpts. |
59907b7 to
c041446
Compare
Member
Author
|
@jasnell please take a look, i've addressed your review |
jasnell
reviewed
Dec 30, 2025
jasnell
reviewed
Dec 30, 2025
jasnell
reviewed
Dec 30, 2025
jasnell
reviewed
Dec 30, 2025
jasnell
reviewed
Dec 30, 2025
jasnell
reviewed
Dec 30, 2025
jasnell
reviewed
Dec 30, 2025
jasnell
reviewed
Dec 30, 2025
jasnell
reviewed
Dec 30, 2025
Collaborator
|
This needs to be rebased. Once it is I'll take another review pass |
Co-authored-by: James M Snell <jsnell@cloudflare.com>
Co-authored-by: James M Snell <jsnell@cloudflare.com>
Co-authored-by: James M Snell <jsnell@cloudflare.com>
Co-authored-by: James M Snell <jsnell@cloudflare.com>
Co-authored-by: James M Snell <jsnell@cloudflare.com>
Co-authored-by: James M Snell <jsnell@cloudflare.com>
Co-authored-by: James M Snell <jsnell@cloudflare.com>
f39c0c7 to
7f2cb8f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
jasnell
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes 3 edge cases in ReadableStream.from cancel behavior.