Do not mark worker tracer unused for duplicate alarms.#5790
Merged
Conversation
Contributor
|
Change itself LGTM, but we should call markUnused() for undelivered requests as part of this PR too. |
Do not mark worker tracer unused for duplicate alarms, since they will be already be marked unused by the undelivered request handling.
643a69e to
7d8cacd
Compare
Contributor
Author
Done. |
fhanau
approved these changes
Dec 30, 2025
fhanau
added a commit
that referenced
this pull request
Jan 5, 2026
Before #5790, this would have avoided "destructed WorkerTracer" warnings when we would construct a WorkerInterface but not end up using it due to the errors being detected later. However, this 1) does not apply for prod where R2 is implemented differently and 2) no longer fixes a warning since the WorkerInterface never has delivered() called. However, it is still good practice to check for errors earlier and avoid memory allocations from the getHttpClient() calls. While this PR is not aiming for completion I also cleaned up a call in web-socket.c++ that may be susceptible to the same issue.
fhanau
added a commit
that referenced
this pull request
Jan 5, 2026
Before #5790, this would have avoided "destructed WorkerTracer" warnings when we would construct a WorkerInterface but not end up using it due to the errors being detected later. However, this 1) does not apply for prod where R2 is implemented differently and 2) no longer fixes a warning since the WorkerInterface never has delivered() called. However, it is still good practice to check for errors earlier and avoid memory allocations from the getHttpClient() calls. While this PR is not aiming for completion I also cleaned up a call in web-socket.c++ that may be susceptible to the same issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduplicated alarm requests are undelivered, so they're already marked unused by the undelivered request handling.