coordinate TransformStream finish operations per spec#5771
Merged
Conversation
02e3f20 to
95e3b6e
Compare
|
The generated output of |
2818fe5 to
7f1342e
Compare
Collaborator
|
I will need to very carefully review this. I should be able to review next week. |
Member
Author
@jasnell ping |
jasnell
reviewed
Feb 21, 2026
Collaborator
|
Looks like there are multiple compile errors and lint issues that need to be addressed. Will review again once those are resolved. |
1c22c9f to
cf2cc2f
Compare
cf2cc2f to
8122e52
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Feb 23, 2026
Collaborator
jasnell
left a comment
There was a problem hiding this comment.
Would prefer a separate compat flag but non-blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress. I still need to figure out how and where to put this behind a pedanticWpt compat flag...
Fixes coordination between close(), cancel() and abort() on TransformStream to properly handles cases where controller.error is called synchronously during finish.
This fixes 11 WPT tests in transform-streams folder.