Skip to content

handle different builtin types in rust jsg registry#5719

Merged
anonrig merged 1 commit intomainfrom
yagiz/rust-jsg-module-registry
Dec 18, 2025
Merged

handle different builtin types in rust jsg registry#5719
anonrig merged 1 commit intomainfrom
yagiz/rust-jsg-module-registry

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Dec 17, 2025

Remove hard coded INTERNAL builtin type and support different types for module registry via rust/jsg integration

@anonrig anonrig requested a review from mikea December 17, 2025 21:22
@anonrig anonrig requested review from a team as code owners December 17, 2025 21:22
@jasnell jasnell added the rust Pull requests that update rust code label Dec 17, 2025
@anonrig anonrig requested a review from jasnell December 17, 2025 23:02
@anonrig anonrig enabled auto-merge (rebase) December 18, 2025 18:09
Copy link
Copy Markdown
Contributor

@mikea mikea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update subject and description - none are informative at all

@anonrig anonrig changed the title handle todo in rust jsg registry handle different builtin types in rust jsg registry Dec 18, 2025
@anonrig anonrig disabled auto-merge December 18, 2025 20:11
@anonrig anonrig force-pushed the yagiz/rust-jsg-module-registry branch from 41aaef1 to feb9722 Compare December 18, 2025 20:15
@anonrig anonrig enabled auto-merge (rebase) December 18, 2025 20:15
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 18, 2025

CodSpeed Performance Report

Merging #5719 will improve performances by 8.93%

Comparing yagiz/rust-jsg-module-registry (feb9722) with main (7b5d410)

Summary

⚡ 1 improvement
✅ 56 untouched
⏩ 34 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
simpleStringBody[Response] 21.4 µs 19.7 µs +8.93%

Footnotes

  1. 34 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@anonrig anonrig merged commit ec2f9b1 into main Dec 18, 2025
42 of 46 checks passed
@anonrig anonrig deleted the yagiz/rust-jsg-module-registry branch December 18, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants