Python snapshots: Refactor hiwire serialization/deserialization#5697
Merged
Python snapshots: Refactor hiwire serialization/deserialization#5697
Conversation
A nonfunctional change. Improve types and move related logic closer together.
ryanking13
approved these changes
Dec 16, 2025
Contributor
ryanking13
left a comment
There was a problem hiding this comment.
LGTM. Do we need to keep add objects to the custom serializer function whenever we need custom serialization?
Contributor
Author
|
Yeah any JavaScript objects we want to support at top level need to be handled here. So we're going to have to add more in the future. Hence tidying up first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nonfunctional change. Improve types and move related logic closer together.