Use RingBuffer in internal.h/c++ instead of std::list#5689
Merged
Conversation
anonrig
approved these changes
Dec 13, 2025
72852ac to
e8bfa68
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ee42f32 to
655a0f0
Compare
The RingBuffer impl provides better performance characteristics for the internal stream buffering needs including reduced memory overhead, improved cache locality, and fewer allocations. This is a small tweak as part of ongoing efforts to optimize/improve the streams impls.
655a0f0 to
5f1848c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RingBuffer impl provides better performance characteristics for the internal stream buffering needs including reduced memory overhead, improved cache locality, and fewer allocations. This is a small tweak as part of ongoing efforts to optimize/improve the streams impls.
As a reminder, the RingBuffer impl was originally done by claude. This PR applies some manual fixups for a couple of things claude got wrong initially.