Remove error thrown if list of converted files is empty#5633
Merged
danlapid merged 1 commit intocloudflare:mainfrom Dec 5, 2025
Merged
Conversation
df5ea96 to
9c8588d
Compare
G4brym
approved these changes
Dec 3, 2025
jasnell
reviewed
Dec 3, 2025
9c8588d to
68db536
Compare
jasnell
approved these changes
Dec 3, 2025
1d27e41 to
439b7e3
Compare
penalosa
approved these changes
Dec 3, 2025
4886e51 to
d92ab7a
Compare
d92ab7a to
379e761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, if the list of converted markdown files that were returned by the call to the internal service was empty we would throw an error.
This makes sense if we only want to convert a single file (the service only accepts a list so we always have to convert a single file to a list of files) because it would mean we got no conversion to return to the user.
For the case where we take a list as input, this doesn't make much sense: it is valid for a user to give us an empty list to begin with.
With this PR, the previous situation becomes valid.