Implement noop versions of the undocumented Console handler callbacks#5610
Merged
petebacondarwin merged 1 commit intomainfrom Dec 1, 2025
Merged
Implement noop versions of the undocumented Console handler callbacks#5610petebacondarwin merged 1 commit intomainfrom
petebacondarwin merged 1 commit intomainfrom
Conversation
This was referenced Nov 29, 2025
jasnell
approved these changes
Nov 29, 2025
vicb
reviewed
Nov 30, 2025
vicb
reviewed
Nov 30, 2025
vicb
reviewed
Nov 30, 2025
vicb
reviewed
Nov 30, 2025
anonrig
approved these changes
Dec 1, 2025
Contributor
Author
|
Moved unresolved unrelated comments over to #5615. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation throws "not implemented" errors when
_stderrErrorHandlerand_stdoutErrorHandlerare called, which is different to Node.js and the unenv polyfill. Now they are simple noops, inline with unenv.This change will allow us to safely remove the node:console polyfill from the Cloudflare unenv preset.
For reference:
Node.js implementation
unenv implementation