Improve node:vm implementation to avoid unnecessary throws#5606
Merged
petebacondarwin merged 3 commits intomainfrom Dec 1, 2025
Merged
Improve node:vm implementation to avoid unnecessary throws#5606petebacondarwin merged 3 commits intomainfrom
node:vm implementation to avoid unnecessary throws#5606petebacondarwin merged 3 commits intomainfrom
Conversation
f0ffde8 to
384122c
Compare
6 tasks
vicb
reviewed
Nov 28, 2025
vicb
reviewed
Nov 28, 2025
vicb
approved these changes
Nov 28, 2025
vicb
approved these changes
Nov 28, 2025
anonrig
approved these changes
Nov 28, 2025
f187b44 to
b0bba9e
Compare
Contributor
Author
|
From what I can tell the internal build job failures are due to unrelated tests failing. It is not clear whether I can do something to fix these. I tried re-running them in case they were just flakes... |
jasnell
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation throws "not implemented" errors on
createContextandnew Script.This is a breaking change from how unenv and Node.js work.
Now they return instances that are safe since they don't have any implementation, or actually also throw "not implemented" errors for their methods.
This change will allow us to safely remove the
node:vmpolyfill from the Cloudflare unenv preset.For reference: