Skip to content

fix: Workflows InstanceStatus with the right types#5575

Merged
pombosilva merged 2 commits intomainfrom
osilva/WOR-1036
Nov 26, 2025
Merged

fix: Workflows InstanceStatus with the right types#5575
pombosilva merged 2 commits intomainfrom
osilva/WOR-1036

Conversation

@pombosilva
Copy link
Copy Markdown
Contributor

@pombosilva pombosilva commented Nov 24, 2025

Fixes WOR-1036.

Fix InstanceStatus to match the runtime return types:

  • error: now returns the object with name and message of the error
  • output: now returns unknown

@pombosilva pombosilva requested a review from a team as a code owner November 24, 2025 15:42
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 24, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@pombosilva
Copy link
Copy Markdown
Contributor Author

pombosilva commented Nov 24, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 24, 2025
@github-actions
@pombosilva has signed the CLA in #5575
164a831
petebacondarwin
petebacondarwin reviewed Nov 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it

workerd/types/defines/workflows.d.ts

Line 84 in 38373eb

error?: string;
where the fix is really needed?

@pombosilva
Copy link
Copy Markdown
Contributor Author

pombosilva commented Nov 24, 2025 •
edited
Loading

Isn't it where the fix is really needed?

Of course!! Thank you 😅 Better have the change in both

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 24, 2025 •
edited
Loading

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@pombosilva pombosilva requested review from a team as code owners November 24, 2025 17:15
@pombosilva pombosilva mentioned this pull request Nov 24, 2025
Closed
@pombosilva pombosilva merged commit 6fd0207 into main Nov 26, 2025
21 checks passed
@pombosilva pombosilva deleted the osilva/WOR-1036 branch November 26, 2025 09:58
@vicb vicb mentioned this pull request Nov 27, 2025
Merged
@pombosilva pombosilva mentioned this pull request Nov 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@danlapid danlapid danlapid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pombosilva @petebacondarwin @danlapid