Skip to content

Allow omitting name while creating dynamic workers#5574

Merged
ketanhwr merged 1 commit intomainfrom
ketan/dyworker-noname
Dec 2, 2025
Merged

Allow omitting name while creating dynamic workers#5574
ketanhwr merged 1 commit intomainfrom
ketan/dyworker-noname

Conversation

@ketanhwr
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 24, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@ketanhwr ketanhwr force-pushed the ketan/dyworker-noname branch from 2568333 to df2bb8e Compare November 25, 2025 11:50
@ketanhwr ketanhwr marked this pull request as ready for review November 25, 2025 12:11
@ketanhwr ketanhwr requested review from a team as code owners November 25, 2025 12:11
@ketanhwr
Copy link
Copy Markdown
Member Author

ketanhwr commented Nov 27, 2025

Oops, looks like the one-off ephemeral isolates aren't behaving well with asan
*** Fatal uncaught kj::Exception: workerd/server/server.c++:302: failed: expected !service.value->isShared(); service still has references after unlinking; service.key = worker-loader-test. Let me see

Should be fixed now

@ketanhwr ketanhwr force-pushed the ketan/dyworker-noname branch from 3e034c3 to 72b9bbf Compare November 27, 2025 23:31
@ketanhwr ketanhwr force-pushed the ketan/dyworker-noname branch from 72b9bbf to c7f1f0a Compare December 2, 2025 11:02
@ketanhwr ketanhwr force-pushed the ketan/dyworker-noname branch from c7f1f0a to 5938f01 Compare December 2, 2025 13:32
@ketanhwr ketanhwr merged commit b636057 into main Dec 2, 2025
40 of 46 checks passed
@ketanhwr ketanhwr deleted the ketan/dyworker-noname branch December 2, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants