Skip to content

smaller exceptions#5464

Merged
mikea merged 2 commits intomainfrom
maizatskyi/2025-11-05-exception-pimpl
Nov 6, 2025
Merged

smaller exceptions#5464
mikea merged 2 commits intomainfrom
maizatskyi/2025-11-05-exception-pimpl

Conversation

@mikea
Copy link
Contributor

@mikea mikea commented Nov 5, 2025

downstream of capnproto/capnproto#2441

@mikea mikea marked this pull request as ready for review November 5, 2025 23:23
@mikea mikea requested review from a team as code owners November 5, 2025 23:23
@mikea mikea requested a review from harrishancock November 5, 2025 23:23
@mikea mikea changed the title update capnp: smaller exceptions smaller exceptions Nov 5, 2025
@anonrig
Copy link
Member

anonrig commented Nov 6, 2025

This somehow broke codspeed builds?

  libc++abi: terminating due to uncaught exception of type kj::ExceptionImpl: workerd/api/http.c++:118: failed: expected c != '\0' && c != '\r' && c != '\n'; jsg.TypeError: Invalid header value.
  stack: 6f18f17 6f15f0c 6f5adbd 6f16a0d 6d0e56 6c9f127 6c95f4f 6c90468 6c8765a 6d0b6d 6d1511 cdb715a 6ceadc 6ce37e 74a2d1 74aff6 743200 ce22925 e1d9d8f e1d9e3f 333ca4

@mikea mikea force-pushed the maizatskyi/2025-11-05-exception-pimpl branch from 53b6673 to a8e3894 Compare November 6, 2025 16:46
@mikea
Copy link
Contributor Author

mikea commented Nov 6, 2025

This somehow broke codspeed builds?

  libc++abi: terminating due to uncaught exception of type kj::ExceptionImpl: workerd/api/http.c++:118: failed: expected c != '\0' && c != '\r' && c != '\n'; jsg.TypeError: Invalid header value.
  stack: 6f18f17 6f15f0c 6f5adbd 6f16a0d 6d0e56 6c9f127 6c95f4f 6c90468 6c8765a 6d0b6d 6d1511 cdb715a 6ceadc 6ce37e 74a2d1 74aff6 743200 ce22925 e1d9d8f e1d9e3f 333ca4

turns out this benchmark is already broken: https://github.com/cloudflare/workerd/actions/runs/19143666391/job/54715486695?pr=5472

@mikea mikea enabled auto-merge (squash) November 6, 2025 18:23
@mikea mikea merged commit 5dec83f into main Nov 6, 2025
30 of 32 checks passed
@mikea mikea deleted the maizatskyi/2025-11-05-exception-pimpl branch November 6, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants