[nfc] Rename *CustomEventImpl -> *CustomEvent#5443
Merged
Conversation
jasnell
approved these changes
Nov 5, 2025
mar-cf
approved these changes
Nov 7, 2025
This is more descriptive as there is no base class for each of these classes, they are all based on WorkerInterface::CustomEvent but the specific event type already makes clear that they serve that purpose.
3d6fb08 to
a92bf0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more descriptive as there is no base class for each of these classes, they are all based on WorkerInterface::CustomEvent but the specific event type already makes clear that they serve that purpose.
(Specifically, for a class like QueueCustomEventImpl, there is no QueueCustomEvent class that it implements, and QueueCustomEvent is sufficient to indicate that this is a specific kind of CustomEvent)