Skip to content

Remove Blob-specific ReadableStreamSource subclass with autogate#5427

Merged
jasnell merged 1 commit intomainfrom
jasnell/blob-use-memorystream
Feb 19, 2026
Merged

Remove Blob-specific ReadableStreamSource subclass with autogate#5427
jasnell merged 1 commit intomainfrom
jasnell/blob-use-memorystream

Conversation

@jasnell
Copy link
Copy Markdown
Collaborator

@jasnell jasnell commented Oct 28, 2025

Use the generic MemoryInputStream to provide the stream for blob data.

Part of getting ready to use the updated ReadableSource adapters

@jasnell jasnell requested a review from harrishancock October 28, 2025 21:28
@jasnell jasnell requested review from a team as code owners October 28, 2025 21:28
@codspeed-hq

This comment was marked as outdated.

@jasnell jasnell force-pushed the jasnell/blob-use-memorystream branch from 14c687b to 1006f86 Compare October 29, 2025 11:37
@jasnell jasnell requested a review from anonrig October 29, 2025 16:01
@jasnell
Copy link
Copy Markdown
Collaborator Author

jasnell commented Oct 30, 2025

Will need to investigate another issue before this can land. Moving to draft.

@jasnell jasnell marked this pull request as draft October 30, 2025 13:38
@jasnell jasnell force-pushed the jasnell/blob-use-memorystream branch from 1006f86 to 9790596 Compare February 13, 2026 23:55
@jasnell jasnell marked this pull request as ready for review February 13, 2026 23:56
@jasnell
Copy link
Copy Markdown
Collaborator Author

jasnell commented Feb 13, 2026

@harrishancock @anonrig ... rebased and updated. Now that the other similar change has been proven to be good and stable in production we can progress with this one as well.

@jasnell jasnell force-pushed the jasnell/blob-use-memorystream branch from 9790596 to cb13b88 Compare February 17, 2026 22:31
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.64%. Comparing base (605e9c5) to head (7eb97d7).

Files with missing lines Patch % Lines
src/workerd/util/autogate.c++ 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5427      +/-   ##
==========================================
- Coverage   70.66%   70.64%   -0.02%     
==========================================
  Files         409      409              
  Lines      109381   109387       +6     
  Branches    18072    18074       +2     
==========================================
- Hits        77289    77279      -10     
- Misses      21244    21260      +16     
  Partials    10848    10848              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell changed the title Remove Blob-specific ReadableStreamSource subclass Remove Blob-specific ReadableStreamSource subclass with autogate Feb 19, 2026
@jasnell jasnell force-pushed the jasnell/blob-use-memorystream branch from cb13b88 to 9f58693 Compare February 19, 2026 14:20
…Source

Use the generic MemoryInputStream to provide the stream for blob data
with autogate
@jasnell jasnell force-pushed the jasnell/blob-use-memorystream branch from 9f58693 to 7eb97d7 Compare February 19, 2026 14:23
@jasnell jasnell merged commit 683f37d into main Feb 19, 2026
22 of 24 checks passed
@jasnell jasnell deleted the jasnell/blob-use-memorystream branch February 19, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants