feat: Add hard timeout support to container startup#5280
Merged
guybedford merged 1 commit intocloudflare:mainfrom Nov 5, 2025
Merged
feat: Add hard timeout support to container startup#5280guybedford merged 1 commit intocloudflare:mainfrom
guybedford merged 1 commit intocloudflare:mainfrom
Conversation
Member
Talador12
commented
Oct 10, 2025
- Add hardTimeoutMs to StartupOptions struct
- Implement hard timeout RPC call during container.start()
- Add setHardTimeout @8 method to container.capnp schema
- Hard timeout is absolute from startup, unlike inactivity timeout
|
All contributors have signed the CLA ✍️ ✅ |
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
gabivlj
reviewed
Oct 10, 2025
6b2a1f8 to
4ceb2b8
Compare
gabivlj
approved these changes
Oct 10, 2025
Contributor
gabivlj
left a comment
There was a problem hiding this comment.
lgtm pending tests passing
justin-mp
reviewed
Oct 13, 2025
justin-mp
reviewed
Oct 13, 2025
justin-mp
reviewed
Oct 13, 2025
justin-mp
reviewed
Oct 13, 2025
justin-mp
reviewed
Oct 13, 2025
4ceb2b8 to
8ee2eee
Compare
cd5f928 to
8d0beed
Compare
CodSpeed Performance ReportMerging #5280 will not alter performanceComparing Summary
Footnotes
|
76429bc to
cb06d70
Compare
cb06d70 to
f243c52
Compare
emily-shen
reviewed
Oct 23, 2025
Contributor
emily-shen
left a comment
There was a problem hiding this comment.
+1 for reverting the string parsing as its inconsistent with setInactivityTimeout. we can do this one layer up in js like we do for setInactivityTimeout.
4ffc45b to
9cdc4a0
Compare
emily-shen
approved these changes
Oct 23, 2025
justin-mp
requested changes
Oct 23, 2025
9cdc4a0 to
84bc93a
Compare
84bc93a to
f770a2a
Compare
justin-mp
approved these changes
Oct 23, 2025
f770a2a to
5c6a9de
Compare
5c6a9de to
1edf460
Compare
jasnell
reviewed
Nov 5, 2025
jasnell
reviewed
Nov 5, 2025
jasnell
approved these changes
Nov 5, 2025
guybedford
approved these changes
Nov 5, 2025
1edf460 to
e32218b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.