Conversation
anonrig
reviewed
Sep 24, 2025
erikcorry
approved these changes
Nov 27, 2025
3d45ee1 to
e8c9633
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
the internal PR that goes with this needs to be rebased before this can land. |
Utility class for capturing the current MPK for the isolate (if enabled) and restoring it when necessary. This is necessary for correct operation when, for instance, we are writing to an ArrayBuffer BackingStore from a coroutine outside the isolate lock. Eventually we should see about making the coroutine itself MPK-aware but this is a good first step that keeps things relatively simple.
e8c9633 to
0e2031e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utility class for capturing the current MPK for the isolate (if enabled) and restoring it when necessary. This is necessary for correct operation when, for instance, we are writing to an ArrayBuffer BackingStore from a coroutine outside the isolate lock. Eventually we should see about making the coroutine itself MPK-aware but this is a good first step that keeps things relatively simple.