Begin consolidating duplicated legacy module registry init code#5088
Merged
Begin consolidating duplicated legacy module registry init code#5088
Conversation
8acfad6 to
82bcda3
Compare
f6ac855 to
f558392
Compare
Base automatically changed from
jasnell/move-capnp-module-to-workerd
to
main
September 16, 2025 20:42
Preparing to share more implementation code between workerd and the internal repo Signed-off-by: James M Snell <jsnell@cloudflare.com>
82bcda3 to
0186e1f
Compare
guybedford
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a fair amount of duplicated code for module initialization between workerd and the internal repo. This starts the process of consolidating by moving a handful of utility methods over to worker-modules.h. A follow-up next step will be to update the internal code to use these from the shared location.
this builds on #5070 which must land first.