Further refine capnp::SchemaLoader ownership#5065
Merged
Conversation
9a12368 to
8e60da4
Compare
guybedford
approved these changes
Sep 13, 2025
In the original work here I missed that the SchemaLoader is needed during the construction of Worker::Script when using the older service worker syntax. This change moves the ownership of the SchemaLoader to the Worker::Script::Impl so that it is available during construction, with the ContextGlobal having a const reference to it. The next step will be to move the capnp modules implementation out from the internal project into workerd.
8e60da4 to
aea252f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original work here I missed that the SchemaLoader is needed during the construction of Worker::Script when using the older service worker syntax. This change moves the ownership of the SchemaLoader to the Worker::Script::Impl so that it is available during construction, with the ContextGlobal having a const reference to it.
The next step will be to move the capnp modules implementation out from the internal project into workerd.