Add the Wrangler e2e test that checks Node.js stuff#5059
Merged
petebacondarwin merged 1 commit intomainfrom Sep 12, 2025
Merged
Add the Wrangler e2e test that checks Node.js stuff#5059petebacondarwin merged 1 commit intomainfrom
petebacondarwin merged 1 commit intomainfrom
Conversation
This test gives us some coverage over changes to the nodejs_compat parts of workerd. Although an e2e test it doesn't take long to run and is not flakey so I think it is worth adding to the workerd PR checks.
d57b71b to
6fcc701
Compare
danlapid
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test gives us some coverage over changes to the nodejs_compat parts of workerd.
Although an e2e test it doesn't take long to run and is not flakey so I think it is worth adding to the workerd PR checks.