Revert revert of performance classes change#5048
Merged
Conversation
f7a0620 to
fbeb026
Compare
|
The generated output of |
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM but I will pull it down and test it with Angular before I approve.
petebacondarwin
approved these changes
Sep 11, 2025
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
OK a local build of this PR works with Angular projects (whereas it fails with workerd@1.20250911.0).
jasnell
reviewed
Sep 11, 2025
jasnell
reviewed
Sep 11, 2025
jasnell
reviewed
Sep 11, 2025
jasnell
reviewed
Sep 11, 2025
jasnell
reviewed
Sep 11, 2025
jasnell
reviewed
Sep 11, 2025
jasnell
reviewed
Sep 11, 2025
Collaborator
|
Looks like you'll need to regenerate the types again |
jasnell
reviewed
Sep 11, 2025
jasnell
reviewed
Sep 11, 2025
jasnell
reviewed
Sep 11, 2025
jasnell
reviewed
Sep 11, 2025
jasnell
reviewed
Sep 11, 2025
6bbf2df to
d98c73e
Compare
jasnell
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second commit includes the changes for the "fix"