Skip to content

chore(bazel): ensure pnpm run outside Bazel has similar behavior#5038

Merged
danlapid merged 1 commit intocloudflare:mainfrom
alexeagle:cleanup1
Sep 15, 2025
Merged

chore(bazel): ensure pnpm run outside Bazel has similar behavior#5038
danlapid merged 1 commit intocloudflare:mainfrom
alexeagle:cleanup1

Conversation

@alexeagle
Copy link
Copy Markdown
Collaborator

rules_js always lays out packages without 'hoisting' so we want any native usage of pnpm to match

rules_js always lays out packages without 'hoisting' so we want any native usage of pnpm to match
@alexeagle alexeagle requested review from a team as code owners September 10, 2025 19:32
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 10, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@danlapid danlapid requested review from fhanau and mikea September 11, 2025 21:45
@fhanau
Copy link
Copy Markdown
Contributor

fhanau commented Sep 15, 2025

This change pertains to pnpm, not Bazel directly – @anonrig should have more context on this

@anonrig
Copy link
Copy Markdown
Member

anonrig commented Sep 15, 2025

This change pertains to pnpm, not Bazel directly – @anonrig should have more context on this

I personally don't see any benefit of using this, since it works right now. But apparently this is a recommendation by rules_js - https://github.com/aspect-build/rules_js/blob/c6ff6f34a570f22920b2836ea605f94c350511b5/docs/pnpm.md?plain=1#L102

@anonrig
Copy link
Copy Markdown
Member

anonrig commented Sep 15, 2025

Does this also require an pnpm install to update pnpm-lock?

@alexeagle
Copy link
Copy Markdown
Collaborator Author

I ran npx pnpm@10.14.0 install and didn't get any changes to the pnpm-lock.yaml file. I think the hoisting behavior would be encoded in the lockfile, if you were currently relying on it. This change just ensures we don't diverge behavior for tools running outside bazel.

@alexeagle
Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@danlapid danlapid merged commit 8961484 into cloudflare:main Sep 15, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants