Track memory snapshot type in SnapshotMeta settings.#5029
Merged
Conversation
4ab1afd to
5052c2b
Compare
hoodmane
reviewed
Sep 10, 2025
5052c2b to
4c3c755
Compare
hoodmane
reviewed
Sep 10, 2025
hoodmane
reviewed
Sep 10, 2025
hoodmane
approved these changes
Sep 10, 2025
Contributor
hoodmane
left a comment
There was a problem hiding this comment.
LGTM, suggested a couple small changes
4c3c755 to
9da0192
Compare
9da0192 to
d04839a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables us to perform additional checks in the validator and ensure we aren't generating a non-dedicated snapshot by mistake.