Skip to content

Exclude Workflows from ctx.exports.#5005

Merged
kentonv merged 1 commit intomainfrom
kenton/ctx-exports-workflows
Sep 11, 2025
Merged

Exclude Workflows from ctx.exports.#5005
kentonv merged 1 commit intomainfrom
kenton/ctx-exports-workflows

Conversation

@kentonv
Copy link
Copy Markdown
Member

@kentonv kentonv commented Sep 7, 2025

It's not currently possible to auto-generate a correct Workflow binding for these. But we were accidentally binding to them as if they were regular stateless entrypoints, which is certainly not what anyone would expect. We should just exclude them instead.

FYI @sidharthachatterjee

@kentonv kentonv requested a review from jasnell September 7, 2025 18:13
@kentonv kentonv requested review from a team as code owners September 7, 2025 18:13
@kentonv kentonv requested a review from danlapid September 10, 2025 17:37
It's not currently possible to auto-generate a correct `Workflow` binding for these. But we were accidentally binding to them as if they were regular stateless entrypoints, which is certainly not what anyone would expect. We should just exclude them instead.
@kentonv kentonv force-pushed the kenton/ctx-exports-workflows branch from 7881fe4 to 7ffc288 Compare September 10, 2025 19:06
@kentonv kentonv merged commit 4118d64 into main Sep 11, 2025
32 of 33 checks passed
@kentonv kentonv deleted the kenton/ctx-exports-workflows branch September 11, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants