[R2 instrumentation] Update R2 span names#5001
Merged
jmorrell-cloudflare merged 1 commit intomainfrom Sep 16, 2025
Merged
Conversation
a5d1284 to
264f8a6
Compare
fhanau
approved these changes
Sep 8, 2025
Contributor
fhanau
left a comment
There was a problem hiding this comment.
- As I understand, we are only modifying the span name for r2-admin APIs, whereas the (presumably more widely used) r2-bucket APIs keep the same name. This sounds like the right approach to me – the name is no longer overloaded, and for the r2-bucket APIs we keep the name that closely fits the name of the JS API (e.g. "head")
Changes here look good – note the comments on the downstream PR before merging though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R2::head()deserves it's own span name, and the bucket admin methods do too.Depends on https://gitlab.cfdata.org/cloudflare/ew/edgeworker/-/merge_requests/11390 to update the allowlist