Conversation
guybedford
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reality, node:console differs from globalThis.console and supports additional features. The existing polyfill implementation for node:console just uses globalThis.console methods underneath. For the sake of removing the polyfills from wrangler, here's the implementation.
Polyfill also adds several variables that is not documented (and not used generally out there) such as the following methods/attributes that I didn't add this to this pull-request. I'm not sure if we should add them. I'm leaving this discussion to the reviewers. Ref: https://github.com/unjs/unenv/blob/main/src/runtime/node/console.ts