Add more R2 instrumentation attributes#4961
Merged
jmorrell-cloudflare merged 5 commits intomainfrom Sep 4, 2025
Merged
Conversation
7ee8b5a to
1b171fd
Compare
…e internal url. Lets store the bucket name separately
1b171fd to
cd2946d
Compare
mar-cf
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename some of the existing attributes and add a few more by passing data down into the R2Bucket class.
cloudflare.binding.typecloudflare.binding.namecloudflare.r2.operationcloudflare.r2.bucketcloudflare.r2.request.keyThe current method of getting the bucket name:
this->adminBucketName()seems to be forR2Adminand does not get populated with the bucket name for users using the normal R2 bindings.