Merged
Conversation
npaun
reviewed
Sep 2, 2025
npaun
approved these changes
Sep 2, 2025
anonrig
reviewed
Sep 2, 2025
anonrig
approved these changes
Sep 3, 2025
vicb
reviewed
Sep 3, 2025
vicb
approved these changes
Sep 3, 2025
Contributor
vicb
left a comment
There was a problem hiding this comment.
LGTM!
I'll work on updating the unenv preset to use process v2 (when enabled) on Monday so that we process v2 can be enabled from Tuesday release or whenever a workerd release containing this PR is available after Tuesday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes experimental for
node:processand sets a compat date of 15 September.In addition, also relaxes flag conditions:
process.stdout.write()can be used when disabling FS.impliedByfor NodeJS compat v2 for process. I misunderstood nodejs compat flag gating here that process can only be physically obtained when compat / compat v2 is enabled, so it makes sense to align with the other builtins rather, and without requiring compat v2.Also updates the reported Node.js version to 22.19.0.