R2 Instrumentation: Move the spans up a level in the call stack#4950
Merged
jmorrell-cloudflare merged 6 commits intomainfrom Sep 2, 2025
Merged
R2 Instrumentation: Move the spans up a level in the call stack#4950jmorrell-cloudflare merged 6 commits intomainfrom
jmorrell-cloudflare merged 6 commits intomainfrom
Conversation
|
The generated output of |
d83c552 to
bb556dd
Compare
4754969 to
fb50fda
Compare
f449a6b to
4319122
Compare
danlapid
reviewed
Sep 2, 2025
danlapid
approved these changes
Sep 2, 2025
Collaborator
danlapid
left a comment
There was a problem hiding this comment.
I don't know if I love the span names or the attribute names but I dislike bike-shedding on names.
The code looks correct.
Base automatically changed from
jmorrell/r2-add-instrumentation-test
to
main
September 2, 2025 17:20
The spans are currently created where the information we want to annotate them with is not available. This moves them up so that they are created inline with the method they are instrumenting. This is similar to what we've done in the KV module.
Nope, this is used by edgeworker. I will modify those in a separate change.
4319122 to
b3e0262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #4949
The spans are currently created where the information we want to annotate them with is not available. This moves them up so that they are created inline with the method they are instrumenting. This is similar to what we've done in the KV module. This also adopts @danlapid's changes in managing span lifetimes from #4861