The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

LGTM. This should also be supported in Streaming Tail Worker, but that can be done in a follow-up PR.

@fhanau can you add some notes on what's required to make that happen?

CI told me to run just generate-types to generate a snapshot, and that requires a review from @cloudflare/wrangler apparently. Pls take a look 🙇‍♀️

LGTM. This should also be supported in Streaming Tail Worker, but that can be done in a follow-up PR.

@fhanau can you add some notes on what's required to make that happen?

I pointed Anna to #4847 as an example for that, but the steps needed to add something to the STW API look like this:

• Add the new field to the right STW event type (i.e. tracing::Onset::Onset, including constructor and clone() method)
• To support the event being sent via RPC, add it to the capnp definition in src/workerd/io/worker-interface.capnp and update the event copyTo() method and the RPC-based constructor.
• Emit the event in the right ToJs function in trace-stream.c++ (in this case ToJs(jsg::Lock& js, const tracing::Onset& onset, StringCache& cache))
• Unlike most JSG APIs, we can't auto-generate types for the STW JS API since we use the ToJs mechanism. Accordingly, add the new field in types/defines/trace.d.ts and then update the generated types snapshot.
• Update any affected tests – that would be src/workerd/api/tail-worker-test.js and some more downstream tests.

As mentioned, this is not needed in this PR.