EW-9282 EW-9451 Further fix errors with Onset event being reported too late#4935
Merged
EW-9282 EW-9451 Further fix errors with Onset event being reported too late#4935
Conversation
…o late In #4881, we fixed the missing/delayed Onset issue for some cases, but to handle logs etc. being created in constructors we need to set the event before invoking JS at all. This requires some slight code duplication so we can access the method name in time.
mar-cf
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4881, we fixed the missing/delayed Onset issue for some cases, but to handle logs etc. being created in constructors we need to set the event before invoking JS at all. This requires some slight code duplication so we can access the method name in time.