Fix critical error transaction handling in sqlite-backed DOs#4934
Merged
Fix critical error transaction handling in sqlite-backed DOs#4934
Conversation
...to make it easier to use similar code for other tests
Using node assertion functions, and also adding checks for in-progress implicit transaction rollbacks.
kentonv
approved these changes
Sep 2, 2025
9848409 to
e526428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sqlite encounters certain "critical errors" during a transaction (like when the db exceeds available storage), it may automatically roll back the transaction. We already have code that attempts to handle rollbacks due to critical errors, but it interacts poorly with the savepoint-based explicit transactions set up by
.transaction()and.transactionSync(), triggering "no such savepoint" internal errors when it attempts to commit or roll back a savepoint that had already been removed. This PR updates the handling to suppress failures due to missing savepoints after critical errors.It also addresses an edge case where a critical error during an explicit
.transaction()did not propagate a broken exception to the caller.