Update the comment for the enable_nodejs_http_server_modules flag#4925
Merged
Update the comment for the enable_nodejs_http_server_modules flag#4925
Conversation
anonrig
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@anonrig @jasnell This PR update the comment as the flag is no more experimental (ref #4722)
One thing I note is that the http and https docs mention:
That does not sound right as I think
enable_nodejs_http_modulesshould also be enabled (not sure about the behavior when only the server flag is used?)If the docs are wrong, could you please create a PR to fix that?
Thanks!