Skip to content

add new nodejs_eol compat flags#4922

Merged
anonrig merged 4 commits intomainfrom
yagiz/add-new-eol-compat-flags
Aug 28, 2025
Merged

add new nodejs_eol compat flags#4922
anonrig merged 4 commits intomainfrom
yagiz/add-new-eol-compat-flags

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Aug 27, 2025

Adds new EOL compat flags to seperate Node.js versions with the end-of-life breaking changes.

@anonrig anonrig requested review from a team as code owners August 27, 2025 20:50
@anonrig anonrig requested a review from a team August 27, 2025 20:50
@anonrig anonrig requested a review from a team as a code owner August 27, 2025 20:50
vicb
vicb previously requested changes Aug 28, 2025
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my inline comments.

IMO the one most important thing is not to use odd release versions as previous even releases outlive them.

Co-authored-by: Victor Berchet <victor@suumit.com>
Co-authored-by: James M Snell <jsnell@cloudflare.com>
Co-authored-by: Yagiz Nizipli <yagiz@cloudflare.com>
@anonrig anonrig dismissed vicb’s stale review August 28, 2025 14:30

Addressed Victor's comments. Dismissing

@anonrig anonrig enabled auto-merge (squash) August 28, 2025 14:35
@anonrig anonrig merged commit 9dfca89 into main Aug 28, 2025
21 checks passed
@anonrig anonrig deleted the yagiz/add-new-eol-compat-flags branch August 28, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants